]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
Telepathy: ignore errors from ack_all_pending_messages()
authorGiovanni Campagna <gcampagna@src.gnome.org>
Mon, 26 Nov 2012 21:30:20 +0000 (22:30 +0100)
committerGiovanni Campagna <gcampagna@src.gnome.org>
Wed, 28 Nov 2012 16:46:39 +0000 (17:46 +0100)
Invalid ID errors from that function are normal, because the set
of IDs to acknowledge may not match the set in the connection manager
due to race conditions.
This is also what empathy does.

https://bugzilla.gnome.org/show_bug.cgi?id=683449

js/ui/components/telepathyClient.js

index b41aa5f9f39321f18b567ae2c9ed3130f59cca82..ddceb345d9f5265e70f7df41aea8397fc8867e4a 100644 (file)
@@ -730,8 +730,7 @@ const ChatSource = new Lang.Class({
     _ackMessages: function() {
         // Don't clear our messages here, tp-glib will send a
         // 'pending-message-removed' for each one.
-        this._channel.ack_all_pending_messages_async(Lang.bind(this, function(src, result) {
-            this._channel.ack_all_pending_messages_finish(result);}));
+        this._channel.ack_all_pending_messages_async(null);
     }
 });